Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

Check in synth script and update gax dependency#43

Merged
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
jkwlui:synth-check-in
Jun 28, 2018
Merged

Check in synth script and update gax dependency#43
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
jkwlui:synth-check-in

Conversation

@jkwlui
Copy link
Copy Markdown
Contributor

@jkwlui jkwlui commented Jun 26, 2018

Fixes #37

ref: googleapis/google-cloud-node#2837

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@jkwlui jkwlui requested a review from a team June 26, 2018 22:34
@jkwlui jkwlui self-assigned this Jun 26, 2018
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 26, 2018

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #43   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851692f...def5cf2. Read the comment docs.

Comment thread synth.py Outdated
library = gapic.node_library(
'container', version,
config_path="/google/container/"
"artman_container.yaml")

This comment was marked as spam.

@JustinBeckwith JustinBeckwith merged commit a8942aa into googleapis:master Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants