test: Add a test that confirms errors are properly passed through for getInstance calls#1606
Conversation
product-auto-label
Bot
added
size: m
| describe('with getInstances', () => { | ||
| const emitGetInstancesError = (stream: any) => { | ||
| const metadata = new grpc.Metadata(); | ||
| metadata.set( |
There was a problem hiding this comment.
Might add a comment here about what the magic buffer numbers mean.
There was a problem hiding this comment.
I think this was in the code snippet I copied because it is realistic to have metadata, but I just removed it because it isn't actually necessary.
danieljbruce
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
Bot
removed
the
automerge
danieljbruce
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
3 participants
Description
This test confirms that errors will bubble up to the user for getInstances calls which allows us to close b/388499540 as not reproducible.
Impact
Just adding a test to confirm correct client library behaviour
Additional Information
Two files were edited: