This repository was archived by the owner on Mar 26, 2026. It is now read-only.
chore(testproxy): Address the TestReadModifyWriteRow_Generic_DeadlineExceeded conformance test#1543
Merged
gcf-merge-on-green[bot] merged 5 commits intomainfrom Dec 13, 2024
Conversation
product-auto-label
Bot
added
size: xs
product-auto-label
Bot
added
size: s
danieljbruce
commented
Dec 13, 2024
| const clientConfig = require('../../src/v2/bigtable_client_config.json'); | ||
| const clientConfig = JSON.parse( | ||
| JSON.stringify(require('../../src/v2/bigtable_client_config.json')) | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
To prevent conformance tests from modifying behaviour in other conformance tests, we must use a copy of the clientConfig so that we don't modify the original and set timeouts for tests that shouldn't be using timeouts.
danieljbruce
commented
Dec 13, 2024
| TODO: In the future we should apply this for all methods, but right | ||
| now doing so results in regressions in the TestSampleRowKeys_Generic_MultiStreams | ||
| and TestSampleRowKeys_Generic_CloseClient conformance tests that need | ||
| to be addressed. |
Contributor
Author
There was a problem hiding this comment.
The regressions have been addressed by making a copy of the clientConfig so now this timeout can apply to all methods.
danieljbruce
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
kevkim-codes
approved these changes
Dec 13, 2024
danieljbruce
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
cindy-peng
approved these changes
Dec 13, 2024
danieljbruce
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
gcf-merge-on-green
Bot
removed
the
automerge
gcf-merge-on-green
Bot
deleted the
380268110-deadline-exceeded-readrows-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The conformance test passes a timeout setting into the
createClienttest proxy service. With this change the timeout setting will now be applied to the client and used in the readModifyWriteRow call. This allows theTestReadModifyWriteRow_Generic_DeadlineExceededconformance test to pass because now the timeout is being used for these calls.