Fix: TestMutateRow_Generic_Headers#1540
Fix: TestMutateRow_Generic_Headers#1540gcf-merge-on-green[bot] merged 16 commits intogoogleapis:mainfrom
Conversation
test: Make the ReadRows service in tests more modular (googleapis#1462)
product-auto-label
Bot
added
size: xs
product-auto-label
Bot
added
size: s
kevkim-codes
added
the
automerge
danieljbruce
left a comment
danieljbruce
left a comment
There was a problem hiding this comment.
Eventually we'll have to get mutateRow service to use the handwritten layer.
| normalizeCallback(async rawRequest => { | ||
| const {request} = rawRequest; | ||
| const {request: mutateRequest} = request; | ||
| const {appProfileId, mutations, tableName, rowKey} = mutateRequest; |
There was a problem hiding this comment.
Eventually we will want the appProfileId to be able to be set per mutateRow call, but the change to use appProfileId to address the test is good for now.
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
Bot
removed
the
automerge
kevkim-codes
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
2 participants
Mutate rows is grabbing the
appProfileIdfrom the client.nodejs-bigtable/src/tabular-api-surface.ts
Line 765 in eb2cd9f
We should modify the test proxy test here to do the same.