This repository was archived by the owner on Mar 26, 2026. It is now read-only.
test: skip failing Windows test#1285
Merged
alexander-fenster merged 2 commits intomainfrom May 22, 2023
Merged
Conversation
product-auto-label
Bot
added
size: xs
alexander-fenster
force-pushed
the
sinon-buffer-from-windows
branch
from
ebedbc5 to
8388168
Compare
igorbernstein2
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like stubbing
Buffer.fromstopped working on Windows withsinon15.1.0 which was recently released. For now let's just disable this test on Windows, I can investigate more what's going on there and either fix the test or report a problem to eithersinonor Node.js.