This repository was archived by the owner on Mar 26, 2026. It is now read-only.
test: Make the mock server test async#1283
Merged
danieljbruce merged 5 commits intogoogleapis:mainfrom May 19, 2023
Merged
Conversation
This test uses the done callback which looks confusing. We should. make the test async for readability.
product-auto-label
Bot
added
size: s
danieljbruce
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
danieljbruce
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
danieljbruce
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alexander-fenster
approved these changes
May 19, 2023
The service does not need to be initialized in a before block. Move it to where the server is initialized.
danieljbruce
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test uses the done callback which looks confusing. We should make the test async for readability.