This repository was archived by the owner on Mar 26, 2026. It is now read-only.
test: Move obtain test instance#1225
Merged
danieljbruce merged 10 commits intogoogleapis:mainfrom Jan 30, 2023
Merged
Conversation
product-auto-label
Bot
added
size: s
danieljbruce
changed the title
bcoe
reviewed
Jan 30, 2023
| TIMESTAMP.setUTCHours(0); | ||
|
|
||
| before(async () => { | ||
| const instance = await obtainTestInstance(); |
There was a problem hiding this comment.
This change makes more sense to me. It's a good cautionary tale that we should avoid await outside the before, after, beforeEach, afterEach blocks.
danieljbruce
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
danieljbruce
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
bcoe
approved these changes
Jan 30, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will reduce the number of failures due to flakey tests by fixing the flakey tests.