Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: Wait for instances to get created in all samples#1149

Merged
danieljbruce merged 3 commits intogoogleapis:mainfrom
danieljbruce:fix-instance-creation-on-more-code-samples
Aug 31, 2022
Merged

fix: Wait for instances to get created in all samples#1149
danieljbruce merged 3 commits intogoogleapis:mainfrom
danieljbruce:fix-instance-creation-on-more-code-samples

Conversation

@danieljbruce
Copy link
Copy Markdown
Contributor

This will ensure that all tests in the samples directory await instance creation so that we don't have any flakey test issues.

@danieljbruce danieljbruce requested review from a team August 29, 2022 21:19
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Aug 29, 2022
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf Bot commented Aug 29, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added api: bigtable Issues related to the googleapis/nodejs-bigtable API. samples Issues that are directly related to samples. labels Aug 29, 2022
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2022
@danieljbruce danieljbruce merged commit c9dd9c6 into googleapis:main Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/nodejs-bigtable API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants