This repository was archived by the owner on Mar 26, 2026. It is now read-only.
docs: Remove unnecessary comment#1115
Merged
danieljbruce merged 11 commits intomainfrom Sep 20, 2022
Merged
Conversation
trusted-contributions-gcf
Bot
added
kokoro:force-run
product-auto-label
Bot
added
the
api: bigtable
gcf-owl-bot
Bot
removed
the
owlbot:run
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
kokoro:force-run
product-auto-label
Bot
added
size: m
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
Bot
changed the title
trusted-contributions-gcf
Bot
added
kokoro:force-run
product-auto-label
Bot
added
size: xl
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
kokoro:force-run
product-auto-label
Bot
added
size: m
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
Bot
changed the title
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
Bot
changed the title
trusted-contributions-gcf
Bot
added
the
kokoro:force-run
Contributor
Author
|
Owl bot is regenerating pull request 1115... |
Contributor
|
@danieljbruce It seems some system tests keep failing for BigTable and it prevents owlbot updates for quite some time. Will you or anyone else be able to look into the failing tests? |
alexander-fenster
approved these changes
Aug 22, 2022
alexander-fenster
approved these changes
Aug 23, 2022
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
alexander-fenster
approved these changes
Sep 1, 2022
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Contributor
Author
|
Owl bot is regenerating pull request 1115... |
PiperOrigin-RevId: 470911839 Source-Link: googleapis/googleapis@3527566 Source-Link: googleapis/googleapis-gen@f16a1d2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9 feat: accept google-gax instance as a parameter Please see the documentation of the client constructor for details. PiperOrigin-RevId: 470332808 Source-Link: googleapis/googleapis@d4a2367 Source-Link: googleapis/googleapis-gen@e97a1ac Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9 fix: better support for fallback mode PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9 feat: Publish new fields PiperOrigin-RevId: 463378622 Source-Link: googleapis/googleapis@8229ab4 Source-Link: googleapis/googleapis-gen@bb82d04 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmI4MmQwNDIyYjhmMmY0MTMxNTg2MjNhOWQxZTA5NDIyYjI2MDRiNSJ9 fix: fixes for routing headers Use gapic-generator-typescript v2.15.3. Committer: @alexander-fenster PiperOrigin-RevId: 462159384 Source-Link: googleapis/googleapis@ff8159e Source-Link: googleapis/googleapis-gen@72d2f0f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzJkMmYwZmFhNDNkZTZmYTgxOTA5NGRhOTA3MGEzMDM2ZDdjYzNlMyJ9 Synchronize new proto/yaml changes. PiperOrigin-RevId: 459539123 Source-Link: googleapis/googleapis@2e0497d Source-Link: googleapis/googleapis-gen@d56d71b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDU2ZDcxYmVkOGY4ZDdiYzk3NzEwNTZmOGM1ZjI2NzFlN2YxMTRhMyJ9 fix: proper camel case for sequences of capital letters Use gapic-generator-typescript v2.15.2. PiperOrigin-RevId: 458552034 Source-Link: googleapis/googleapis@ae65014 Source-Link: googleapis/googleapis-gen@b09ede4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjA5ZWRlNDM1Y2NlMTEwNDQ2ZDRhYjlmNjJhMDgxYjU3MWQzN2UzZiJ9 feat: Cloud Bigtable Undelete Table service and message proto files PiperOrigin-RevId: 457778403 Source-Link: googleapis/googleapis@2b0fe3b Source-Link: googleapis/googleapis-gen@ca2a2c5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2EyYTJjNTVjYWZjYTRiODc2MzA1YjBiMTJmNzZjZTBmMTY2ZGRjYyJ9 feat: Add storage_utilization_gib_per_node to Autoscaling target PiperOrigin-RevId: 457776307 Source-Link: googleapis/googleapis@982bb69 Source-Link: googleapis/googleapis-gen@0aff3eb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGFmZjNlYmNjOGZiM2MxMGI2NzFlZTM4NmI0ZDI2MzAxMmQzZDAxMyJ9 feat: support regapic LRO Use gapic-generator-typescript v2.15.1. PiperOrigin-RevId: 456946341 Source-Link: googleapis/googleapis@88fd18d Source-Link: googleapis/googleapis-gen@accfa37 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9
…est, and UpdateTable API in **stable** proto to external customers PiperOrigin-RevId: 474010093 Source-Link: googleapis/googleapis@e210283 Source-Link: googleapis/googleapis-gen@46d5c58 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkNWM1OGI2NDdlYTljMDUwYTAwYzNiNjgyNWEzY2YzMTZmODk0OCJ9
Contributor
|
The tests are failing due to inconsistencies from an upgrade to gax 3.0.0. |
PiperOrigin-RevId: 474338479 Source-Link: googleapis/googleapis@d5d35e0 Source-Link: googleapis/googleapis-gen@efcd3f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9
alexander-fenster
approved these changes
Sep 14, 2022
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
PiperOrigin-RevId: 474807836 Source-Link: googleapis/googleapis@dfd68f7 Source-Link: googleapis/googleapis-gen@fe305e0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmUzMDVlMDI1MmJjOWE4ODQ2NmUxYjk2YzJmMjQ2NGRkNzI5Yjk3OCJ9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 474807836
Source-Link: googleapis/googleapis@dfd68f7
Source-Link: https://github.com/googleapis/googleapis-gen/commit/fe305e0252bc9a88466e1b96c2f2464dd729b978
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmUzMDVlMDI1MmJjOWE4ODQ2NmUxYjk2YzJmMjQ2NGRkNzI5Yjk3OCJ9
fix: preserve default values in x-goog-request-params header
PiperOrigin-RevId: 474338479
Source-Link: googleapis/googleapis@d5d35e0
Source-Link: https://github.com/googleapis/googleapis-gen/commit/efcd3f93962a103f68f003e2a1eecde6fa216a27
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9
feat: Publish CBT deletion_protection field in Table, UpdateTableRequest, and UpdateTable API in stable proto to external customers
PiperOrigin-RevId: 474010093
Source-Link: googleapis/googleapis@e210283
Source-Link: https://github.com/googleapis/googleapis-gen/commit/46d5c58b647ea9c050a00c3b6825a3cf316f8948
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkNWM1OGI2NDdlYTljMDUwYTAwYzNiNjgyNWEzY2YzMTZmODk0OCJ9
fix: use _gaxModule when accessing gax for bundling
PiperOrigin-RevId: 470911839
Source-Link: googleapis/googleapis@3527566
Source-Link: https://github.com/googleapis/googleapis-gen/commit/f16a1d224f00a630ea43d6a9a1a31f566f45cdea
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9
feat: accept google-gax instance as a parameter
Please see the documentation of the client constructor for details.
PiperOrigin-RevId: 470332808
Source-Link: googleapis/googleapis@d4a2367
Source-Link: https://github.com/googleapis/googleapis-gen/commit/e97a1ac204ead4fe7341f91e72db7c6ac6016341
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9
fix: better support for fallback mode
PiperOrigin-RevId: 468790263
Source-Link: googleapis/googleapis@873ab45
Source-Link: https://github.com/googleapis/googleapis-gen/commit/cb6f37aeff2a3472e40a7bbace8c67d75e24bee5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
feat: Publish new fields
PiperOrigin-RevId: 463378622
Source-Link: googleapis/googleapis@8229ab4
Source-Link: https://github.com/googleapis/googleapis-gen/commit/bb82d0422b8f2f413158623a9d1e09422b2604b5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmI4MmQwNDIyYjhmMmY0MTMxNTg2MjNhOWQxZTA5NDIyYjI2MDRiNSJ9
fix: fixes for routing headers
Use gapic-generator-typescript v2.15.3.
Committer: @alexander-fenster
PiperOrigin-RevId: 462159384
Source-Link: googleapis/googleapis@ff8159e
Source-Link: https://github.com/googleapis/googleapis-gen/commit/72d2f0faa43de6fa819094da9070a3036d7cc3e3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzJkMmYwZmFhNDNkZTZmYTgxOTA5NGRhOTA3MGEzMDM2ZDdjYzNlMyJ9
Synchronize new proto/yaml changes.
PiperOrigin-RevId: 459539123
Source-Link: googleapis/googleapis@2e0497d
Source-Link: https://github.com/googleapis/googleapis-gen/commit/d56d71bed8f8d7bc9771056f8c5f2671e7f114a3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDU2ZDcxYmVkOGY4ZDdiYzk3NzEwNTZmOGM1ZjI2NzFlN2YxMTRhMyJ9
fix: proper camel case for sequences of capital letters
Use gapic-generator-typescript v2.15.2.
PiperOrigin-RevId: 458552034
Source-Link: googleapis/googleapis@ae65014
Source-Link: https://github.com/googleapis/googleapis-gen/commit/b09ede435cce110446d4ab9f62a081b571d37e3f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjA5ZWRlNDM1Y2NlMTEwNDQ2ZDRhYjlmNjJhMDgxYjU3MWQzN2UzZiJ9
feat: Cloud Bigtable Undelete Table service and message proto files
PiperOrigin-RevId: 457778403
Source-Link: googleapis/googleapis@2b0fe3b
Source-Link: https://github.com/googleapis/googleapis-gen/commit/ca2a2c55cafca4b876305b0b12f76ce0f166ddcc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2EyYTJjNTVjYWZjYTRiODc2MzA1YjBiMTJmNzZjZTBmMTY2ZGRjYyJ9
feat: Add storage_utilization_gib_per_node to Autoscaling target
PiperOrigin-RevId: 457776307
Source-Link: googleapis/googleapis@982bb69
Source-Link: https://github.com/googleapis/googleapis-gen/commit/0aff3ebcc8fb3c10b671ee386b4d263012d3d013
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGFmZjNlYmNjOGZiM2MxMGI2NzFlZTM4NmI0ZDI2MzAxMmQzZDAxMyJ9
feat: support regapic LRO
Use gapic-generator-typescript v2.15.1.
PiperOrigin-RevId: 456946341
Source-Link: googleapis/googleapis@88fd18d
Source-Link: https://github.com/googleapis/googleapis-gen/commit/accfa371f667439313335c64042b063c1c53102e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9