Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

feat: enable retries for RESOURCE_EXHAUSTED an simplify error codes#1070

Merged
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
igorbernstein2:res-ex
Apr 13, 2022
Merged

feat: enable retries for RESOURCE_EXHAUSTED an simplify error codes#1070
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
igorbernstein2:res-ex

Conversation

@igorbernstein2
Copy link
Copy Markdown
Contributor

Unify retriable status codes for ReadRows and MutateRows to be DEADLINE_EXCEEDED - RESOURCE_EXHAUSTED, ABORTED, UNAVAILABLE.

Unify retriable status codes for ReadRows and MutateRows to be DEADLINE_EXCEEDED -  RESOURCE_EXHAUSTED, ABORTED, UNAVAILABLE.
@igorbernstein2 igorbernstein2 requested review from a team April 13, 2022 19:01
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Apr 13, 2022
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2022
Copy link
Copy Markdown
Contributor

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not too sure why idempotent requests would retry based on a different error set before so it seems reasonable to retry based on the same set of errors no matter what type of call we make as per the changes.

Comment thread test/table.ts
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 6832df7 into googleapis:main Apr 13, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2022
@igorbernstein2 igorbernstein2 deleted the res-ex branch April 13, 2022 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants