fix: Paused scan test is now fixed (#1539)

kevkim-codes · web-flow · commit d009a8f9bb86 · 2024-12-16T20:08:21.000Z
Remove paused scan from failing test log. PR in test proxy now fixes this: https://togithub.com/googleapis/cloud-bigtable-clients-test/pull/211. Also adds some minor syntax updates to the test proxy server.
diff --git a/testproxy/index.js b/testproxy/index.js
@@ -49,7 +49,6 @@ function startServer(service) {
     grpc.ServerCredentials.createInsecure(),
     () => {
       console.log(`grpc server started on port: ${port}`);
-      server.start();
     }
   );
 }
@@ -58,7 +57,7 @@ async function main() {
   const descriptor = await loadDescriptor();
   const {service} =
     descriptor.google.bigtable.testproxy.CloudBigtableV2TestProxy;
-  await startServer(service);
+  startServer(service);
 }
 
 main();
diff --git a/testproxy/known_failures.txt b/testproxy/known_failures.txt
@@ -11,7 +11,6 @@ TestReadRow_Retry_WithRoutingCookie\|
 TestReadRow_Retry_WithRetryInfo\|
 TestReadRows_ReverseScans_FeatureFlag_Enabled\|
 TestReadRows_NoRetry_OutOfOrderError_Reverse\|
-TestReadRows_Retry_PausedScan\|
 TestReadRows_Retry_LastScannedRow_Reverse\|
 TestReadRows_Retry_WithRoutingCookie\|
 TestReadRows_Retry_WithRoutingCookie_MultipleErrorResponses\|

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,6 @@ function startServer(service) {`
`49`	`49`	`grpc.ServerCredentials.createInsecure(),`
`50`	`50`	`() => {`
`51`	`51`	console.log(`grpc server started on port: ${port}`);
`52`		`- server.start();`
`53`	`52`	`}`
`54`	`53`	`);`
`55`	`54`	`}`
`@@ -58,7 +57,7 @@ async function main() {`
`58`	`57`	`const descriptor = await loadDescriptor();`
`59`	`58`	`const {service} =`
`60`	`59`	`descriptor.google.bigtable.testproxy.CloudBigtableV2TestProxy;`
`61`		`- await startServer(service);`
	`60`	`+ startServer(service);`
`62`	`61`	`}`
`63`	`62`
`64`	`63`	`main();`