correct the backups samples

danieljbruce · danieljbruce · commit 7241dbeb5099 · 2025-09-02T17:28:04.000-04:00
diff --git a/samples/test/backups.js b/samples/test/backups.js
@@ -37,17 +37,36 @@ describe('backups', async () => {
   const backup = cluster.backup(BACKUP_ID);
 
   async function createTestBackup(backupId) {
-    const [backup, operation] = await cluster.createBackup(backupId, {
-      table,
-      expireTime: new Date(Date.now() + 60 * 60 * 1000), // 1 hour from now
-    });
-    await operation.promise();
+    const {BigtableTableAdminClient} = require('@google-cloud/bigtable').v2;
+    const adminClient = new BigtableTableAdminClient();
+    const projectId = await adminClient.getProjectId();
+    const request = {
+      parent: adminClient.clusterPath(projectId, INSTANCE_ID, CLUSTER_ID),
+      backupId: backupId,
+      backup: {
+        sourceTable: adminClient.tablePath(projectId, INSTANCE_ID, TABLE_ID),
+        expireTime: new Date(Date.now() + 60 * 60 * 1000), // 1 hour from now
+      },
+    };
+    const [operation] = await adminClient.createBackup(request);
+    const [backup] = await operation.promise();
     return backup;
   }
 
   before(async () => {
-    await table.create();
-    await table.createFamily('follows');
+    const {BigtableTableAdminClient} = require('@google-cloud/bigtable').v2;
+    const adminClient = new BigtableTableAdminClient();
+    const projectId = await adminClient.getProjectId();
+    const request = {
+      parent: adminClient.instancePath(projectId, INSTANCE_ID),
+      tableId: TABLE_ID,
+      table: {
+        columnFamilies: {
+          follows: {},
+        },
+      },
+    };
+    await adminClient.createTable(request);
     await table.insert([
       {
         key: 'alincoln',
@@ -71,10 +90,15 @@ describe('backups', async () => {
 
   after(async () => {
     async function reapBackups(instance) {
-      const [backups] = await instance.getBackups();
+      const {BigtableTableAdminClient} = require('@google-cloud/bigtable').v2;
+      const adminClient = new BigtableTableAdminClient();
+      const projectId = await adminClient.getProjectId();
+      const [backups] = await adminClient.listBackups({
+        parent: adminClient.instancePath(projectId, instance.id),
+      });
       return Promise.all(
         backups.map(backup => {
-          return backup.delete({timeout: 50 * 1000});
+          return adminClient.deleteBackup({name: backup.name});
         }),
       );
     }
@@ -103,34 +127,44 @@ describe('backups', async () => {
   });
 
   it('should get an existing backup', async () => {
-    // Refresh our copy of the backup metadata.
-    const [metadata] = await backup.getMetadata();
+    const {BigtableTableAdminClient} = require('@google-cloud/bigtable').v2;
+    const adminClient = new BigtableTableAdminClient();
+    const projectId = await adminClient.getProjectId();
+    const request = {
+      name: adminClient.backupPath(
+        projectId,
+        INSTANCE_ID,
+        CLUSTER_ID,
+        BACKUP_ID,
+      ),
+    };
+    const [metadata] = await adminClient.getBackup(request);
 
     const stdout = execSync(
       `node ./backups.get.js ${INSTANCE_ID} ${TABLE_ID} ${CLUSTER_ID} ${BACKUP_ID}`,
     );
     assert.include(stdout, `The backup is ${metadata.sizeBytes} bytes.`);
     assert.include(
       stdout,
-      `The backup will auto-delete at ${metadata.expireDate.toISOString()}`,
+      `The backup will auto-delete at ${new Date(metadata.expireTime.seconds * 1000).toISOString()}`,
     );
     assert.include(
       stdout,
-      `The backup finished being created at ${metadata.endTime.toISOString()}`,
+      `The backup finished being created at ${new Date(metadata.endTime.seconds * 1000).toISOString()}`,
     );
   });
 
   it('should get existing backups', async () => {
-    const [backupsFromInstance] = await instance.listBackups();
-    const [backupsFromCluster] = await cluster.listBackups();
+    const {BigtableTableAdminClient} = require('@google-cloud/bigtable').v2;
+    const adminClient = new BigtableTableAdminClient();
+    const projectId = await adminClient.getProjectId();
+    const [backupsFromCluster] = await adminClient.listBackups({
+      parent: adminClient.clusterPath(projectId, INSTANCE_ID, CLUSTER_ID),
+    });
 
     const stdout = execSync(
       `node ./backups.list.js ${INSTANCE_ID} ${TABLE_ID} ${CLUSTER_ID}`,
     );
-    assert.include(
-      stdout,
-      `${backupsFromInstance.length} backups returned from the instance.`,
-    );
     assert.include(
       stdout,
       `${backupsFromCluster.length} backups returned from the cluster.`,
@@ -149,18 +183,33 @@ describe('backups', async () => {
     const backupId = generateId();
     const backup = await createTestBackup(backupId);
 
-    const oldExpireTime = backup.expireTime.toISOString();
+    const oldExpireTime = new Date(
+      backup.expireTime.seconds * 1000,
+    ).toISOString();
 
     const stdout = execSync(
       `node ./backups.update.js ${INSTANCE_ID} ${TABLE_ID} ${CLUSTER_ID} ${backupId}`,
     );
 
-    const newExpireTime = backup.expireTime.toISOString();
+    const {BigtableTableAdminClient} = require('@google-cloud/bigtable').v2;
+    const adminClient = new BigtableTableAdminClient();
+    const projectId = await adminClient.getProjectId();
+    const [updatedBackup] = await adminClient.getBackup({
+      name: adminClient.backupPath(
+        projectId,
+        INSTANCE_ID,
+        CLUSTER_ID,
+        backupId,
+      ),
+    });
+    const newExpireTime = new Date(
+      updatedBackup.expireTime.seconds * 1000,
+    ).toISOString();
     assert.notStrictEqual(oldExpireTime, newExpireTime);
 
     assert.include(
       stdout,
-      `The backup will now auto-delete at ${backup.metadata.expireDate}.`,
+      `The backup will now auto-delete at ${newExpireTime}.`,
     );
   });
 });
