Move obtainTestInstance into the before block for

danieljbruce · danieljbruce · commit 3eb0d8fd8ed1 · 2023-01-27T16:24:06.000-05:00
backups
diff --git a/samples/test/backups.js b/samples/test/backups.js
@@ -25,14 +25,12 @@ describe('backups', async () => {
   const TABLE_ID = generateId();
   const BACKUP_ID = generateId();
 
-  const instance = await obtainTestInstance();
-
-  const INSTANCE_ID = instance.id;
-  const CLUSTER_ID = instance.id; // The test function uses the same name.
-
-  const table = instance.table(TABLE_ID);
-  const cluster = instance.cluster(INSTANCE_ID);
-  const backup = cluster.backup(BACKUP_ID);
+  let instance;
+  let INSTANCE_ID;
+  let CLUSTER_ID;
+  let table;
+  let cluster;
+  let backup;
 
   async function createTestBackup(backupId) {
     const [backup, operation] = await cluster.createBackup(backupId, {
@@ -44,6 +42,15 @@ describe('backups', async () => {
   }
 
   before(async () => {
+    instance = await obtainTestInstance();
+
+    INSTANCE_ID = instance.id;
+    CLUSTER_ID = instance.id; // The test function uses the same name.
+
+    table = instance.table(TABLE_ID);
+    cluster = instance.cluster(INSTANCE_ID);
+    backup = cluster.backup(BACKUP_ID);
+
     await table.create();
     await table.createFamily('follows');
     await table.insert([
diff --git a/samples/test/util.js b/samples/test/util.js
@@ -50,6 +50,7 @@ async function getStaleInstances() {
  * the result.
  */
 async function obtainTestInstance() {
+  // Note: Do not use this function if it is only inside a describe block.
   if (!obtainPromise) {
     obtainPromise = createTestInstance();
   }

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ async function getStaleInstances() {`
`50`	`50`	`* the result.`
`51`	`51`	`*/`
`52`	`52`	`async function obtainTestInstance() {`
	`53`	`+ // Note: Do not use this function if it is only inside a describe block.`
`53`	`54`	`if (!obtainPromise) {`
`54`	`55`	`obtainPromise = createTestInstance();`
`55`	`56`	`}`