fix: do not cancel stream after server returned ok or cancelled status (#1029)

mutianf · web-flow · commit 33754a2c0cc1 · 2022-03-16T15:58:51.000-04:00
* fix: do not cancel stream after server returned ok or cancelled status

* remove comment

* lint

* lint
diff --git a/src/table.ts b/src/table.ts
@@ -728,7 +728,7 @@ Please use the format 'prezzy' or '${instance.name}/tables/prezzy'.`);
   createReadStream(opts?: GetRowsOptions) {
     const options = opts || {};
     const maxRetries = is.number(this.maxRetries) ? this.maxRetries! : 3;
-    let activeRequestStream: AbortableDuplex;
+    let activeRequestStream: AbortableDuplex | null;
     let rowKeys: string[];
     const ranges = options.ranges || [];
     let filter: {} | null;
@@ -786,7 +786,6 @@ Please use the format 'prezzy' or '${instance.name}/tables/prezzy'.`);
     userStream.end = () => {
       rowStream?.unpipe(userStream);
       if (activeRequestStream) {
-        // TODO: properly end the stream instead of abort
         activeRequestStream.abort();
       }
       return end();
@@ -927,23 +926,28 @@ Please use the format 'prezzy' or '${instance.name}/tables/prezzy'.`);
 
       rowStream = pumpify.obj([requestStream, chunkTransformer, toRowStream]);
 
-      rowStream.on('error', (error: ServiceError) => {
-        if (IGNORED_STATUS_CODES.has(error.code)) {
-          // We ignore the `cancelled` "error", since we are the ones who cause
-          // it when the user calls `.abort()`.
-          userStream.end();
-          return;
-        }
-        rowStream.unpipe(userStream);
-        if (
-          numRequestsMade <= maxRetries &&
-          RETRYABLE_STATUS_CODES.has(error.code)
-        ) {
-          makeNewRequest();
-        } else {
-          userStream.emit('error', error);
-        }
-      });
+      rowStream
+        .on('error', (error: ServiceError) => {
+          rowStream.unpipe(userStream);
+          activeRequestStream = null;
+          if (IGNORED_STATUS_CODES.has(error.code)) {
+            // We ignore the `cancelled` "error", since we are the ones who cause
+            // it when the user calls `.abort()`.
+            userStream.end();
+            return;
+          }
+          if (
+            numRequestsMade <= maxRetries &&
+            RETRYABLE_STATUS_CODES.has(error.code)
+          ) {
+            makeNewRequest();
+          } else {
+            userStream.emit('error', error);
+          }
+        })
+        .on('end', () => {
+          activeRequestStream = null;
+        });
       rowStream.pipe(userStream);
       numRequestsMade++;
     };
