Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

chore!: upgrade to node 18#542

Merged
leahecole merged 29 commits intomainfrom
node18-2
Apr 4, 2025
Merged

chore!: upgrade to node 18#542
leahecole merged 29 commits intomainfrom
node18-2

Conversation

@leahecole
Copy link
Copy Markdown
Contributor

@leahecole leahecole commented Mar 27, 2025 •
edited
Loading

fixes b/397529720
I think this also fixes #540

gcf-owl-bot Bot and others added 20 commits October 25, 2024 16:07
@gcf-owl-bot
feat: add experimental ArrowData type and arrow_data field within App…
b8ace75 
…endRowsRequest

PiperOrigin-RevId: 684900949

Source-Link: googleapis/googleapis@b49a983

Source-Link: googleapis/googleapis-gen@34ddd03
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzRkZGQwMzk5Mzg2YWViMWQ0YWI1ZDM5N2E2ZGNjZTU5MDhhMTZmMCJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
fb90507 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
chore: remove redundant gRPC service config file
d543ab4 
feat: specify retry configuration

PiperOrigin-RevId: 712493958

Source-Link: googleapis/googleapis@29aea41

Source-Link: googleapis/googleapis-gen@04bcbab
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDRiY2JhYjQ1MDU5ODllOTg0YjE0MDNkNDM4ZmZmYzAzMTIxNDRhZiJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
e89120e 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
feat: paging changes for bigquery
843680d 
fix: add x-goog-request params to headers for LRO-polling methods
fix: remove extra protos in ESM & capture ESM in headers
docs: update comments for a Nodejs stream object

PiperOrigin-RevId: 721038181

Source-Link: googleapis/googleapis@331a41a

Source-Link: googleapis/googleapis-gen@e81b4c5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTgxYjRjNWI1MjA4ODk1ZjY2M2EyNDA0ODYxNWE1OWQ1NjM2ZjQxNSJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
486b995 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
chore: update copyright year for auto-generated protos
defac79 
PiperOrigin-RevId: 731694023

Source-Link: googleapis/googleapis@12fc2f9

Source-Link: googleapis/googleapis-gen@ec9b041
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWM5YjA0MTRhYWM1Y2U2MTFmZjU3NjU1YTRkYTY1NWJkZGZmZjBmZSJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
4949373 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
chore: update copyright year for auto-generated protos
1b1bd97 
PiperOrigin-RevId: 731731294

Source-Link: googleapis/googleapis@a2dbd2d

Source-Link: googleapis/googleapis-gen@c28cf03
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzI4Y2YwMzRlMTM4ZWEwOTg3MDYyYTMzODUwMDIxMWI3YjRmNDM2MiJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
4049f01 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
chore: update copyright year for auto-generated protos
93367e1 
PiperOrigin-RevId: 732130682

Source-Link: googleapis/googleapis@9415ba0

Source-Link: googleapis/googleapis-gen@2905f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwNWY4MzM3NTZjMmIyMGIzMjgyYmU4NGI1MTFlMDQwZmU1NGYzMyJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
bd14db5 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
chore: update typescript gapic generator to 4.8.1
cd6379d 
feat: add request/response debug logging to gapics, update templates to gax 5 and node 18 (#1671)
fix: add json files to tsconfig templates (#1692) (ba6be1d)

PiperOrigin-RevId: 735896588

Source-Link: googleapis/googleapis@3419af7

Source-Link: googleapis/googleapis-gen@f35ba11
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjM1YmExMTQyZjRlMTY4MjIyMzI3ZDg5MmI1ZjZlZTkwOGU1ZDQ2MSJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
52f0dee 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
feat: await/catch promises, and update listOperationsAsync return type
9236dc7 
PiperOrigin-RevId: 738212310

Source-Link: googleapis/googleapis@803b234

Source-Link: googleapis/googleapis-gen@4f44bd2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
df98c2e 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@leahecole
run migrate script
c7a7d28
@leahecole
resolve compile errors
a25f8b7
@leahecole
npm run fix
3d1aeee
@leahecole
fix floating promise lint error
154fffb
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Mar 27, 2025
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Mar 27, 2025 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs-devsite.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/publish.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/system-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.bat - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/trampoline_v2.sh - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool
  • README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

@product-auto-label product-auto-label Bot added the api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. label Mar 27, 2025
@leahecole leahecole changed the title Node18 2 chore!: upgrade to node 18 Mar 27, 2025
@leahecole
Copy link
Copy Markdown
Contributor Author

leahecole commented Apr 2, 2025

I think that some changes got lost in a force push that are causing compile errors - https://github.com/googleapis/nodejs-bigquery-storage/compare/3ee7c38228ee68b64fe7fd8509ef41d6623ee67b..8d52d12a9ff49d9e90a297923437088ff5c8e51b

Some of these later got reverted, but the changes to src/adapt/proto_mappings.ts and src/adapt/proto.ts are missing. I am going to rollback to before you commit and then try re-adding your stuff @sofisl

@leahecole leahecole added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2025
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2025
@leahecole leahecole marked this pull request as ready for review April 2, 2025 21:21
@leahecole leahecole requested review from a team, Linchin, alvarowolfx and sofisl and removed request for Linchin April 2, 2025 21:21
@sofisl sofisl added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2025
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2025
@leahecole leahecole added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2025
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2025
alvarowolfx
alvarowolfx reviewed Apr 4, 2025
View reviewed changes
Comment thread src/reader/read_client.ts

close() {
this._client.close();
this._client.close().catch(err => {
Copy link
Copy Markdown
Contributor

@alvarowolfx alvarowolfx Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change is needed for the upgrade ?

Copy link
Copy Markdown
Contributor Author

@leahecole leahecole Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question! It's from this generator update googleapis/gapic-generator-typescript#1697 - we changed our lint rules and don't allow floating promises anymore, so you'll see more catch blocks like these in all of our code

alvarowolfx
alvarowolfx approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahecole leahecole merged commit b3eb245 into main Apr 4, 2025
17 checks passed
@leahecole leahecole deleted the node18-2 branch April 4, 2025 14:28
@release-please release-please Bot mentioned this pull request Apr 4, 2025
Merged
@release-please release-please Bot mentioned this pull request Aug 13, 2025
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sofisl sofisl Awaiting requested review from sofisl

1 more reviewer

@alvarowolfx alvarowolfx alvarowolfx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nightlies are failing

3 participants

@leahecole @alvarowolfx @sofisl