This repository was archived by the owner on Mar 5, 2026. It is now read-only.
fix: required table fields with value expression should be proto optional#532
Merged
alvarowolfx merged 3 commits intomainfrom Jan 8, 2025
Merged
fix: required table fields with value expression should be proto optional#532alvarowolfx merged 3 commits intomainfrom
alvarowolfx merged 3 commits intomainfrom
Conversation
product-auto-label
Bot
added
size: s
6 tasks
leahecole
changed the title
leahecole
approved these changes
Jan 6, 2025
Contributor
leahecole
left a comment
leahecole
left a comment
There was a problem hiding this comment.
LGTM, but would like @shollyman to do a confidence check on this logic
shollyman
approved these changes
Jan 6, 2025
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
This is an interesting interaction with schema inference, given that the client side required-ness isn't strictly compatible with the default value feature. Is it worth adding some more documentation to the adapt package to explain why this happens?
product-auto-label
Bot
added
size: m
alvarowolfx
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a BigQuery table column mode is set to
REQUIRED, when converted to a protobuf label, it was being converted asLABEL_REQUIRED. This would make protobufjs encoding methods to set an empty value to it when converting to the wire format. But if the column has adefaultValueExpressionand we want the backend to fill the data, we need to let the value staynull | undefined.This PR checks if there is a
defaultValueExpressiondefined on the column and change the label toLABEL_OPTIONALto let the backend fill the data.Fixes #531 🦕