Emit stream events in stream_connection.ts#530
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
Bot
added
size: xs
* feat: emit stream events in stream_connection.ts (googleapis#529)
|
I'm having some difficulty with the Google CLA - I have signed it on behalf of the organisation and added the members to our group [email protected] but it doesn't seem to be picking it up. It might be worth closing this PR and making the changes yourself. I will continue with my workaround for now. |
alvarowolfx
requested review from
alvarowolfx
and removed request for
Linchin
|
thanks for the PR @CJxD, I'll take over from here and try to add those improvements. |
|
Superseded by #533 |
2 participants
When using the managedwriter, I found that the connection often needs to reconnect, but my calling code was unable to determine when this happens.
In this commit I have forwarded the various events from the underlying connection, except 'close' is only called when the stream_connection has been instructed to close, and a new event 'reconnect' is emitted when the stream has been closed and reopened.
Fixes #529 🦕