This repository was archived by the owner on Mar 5, 2026. It is now read-only.
fix: arrow parsing for nested and nullable fields#519
Merged
leahecole merged 3 commits intogoogleapis:mainfrom Oct 23, 2024
Merged
fix: arrow parsing for nested and nullable fields#519leahecole merged 3 commits intogoogleapis:mainfrom
leahecole merged 3 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: m
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
leahecole
suggested changes
Oct 17, 2024
Contributor
leahecole
left a comment
leahecole
left a comment
There was a problem hiding this comment.
mostly questions! Probably just needs a few comments for other maintainers who might not be as familiar with arrow
leahecole
approved these changes
Oct 17, 2024
Contributor
leahecole
left a comment
leahecole
left a comment
There was a problem hiding this comment.
I added two suggestions but otherwise lgtm
alvarowolfx
added
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves parsing of arrow records to TableRow format by increasing test coverage and checking arrow data types.
Fixes #518 🦕