Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

ci: fix npm pack/publish by removing import package.json#458

Merged
alvarowolfx merged 1 commit intogoogleapis:mainfrom
alvarowolfx:ci-fix-npm-build-import-package
May 10, 2024
Merged

ci: fix npm pack/publish by removing import package.json#458
alvarowolfx merged 1 commit intogoogleapis:mainfrom
alvarowolfx:ci-fix-npm-build-import-package

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

v4.7.0 was published with no source files. We managed to reproduce the issue by using nvm and setting to node to v14 and npm v6, which seems to have issues when a package.json exists on the build folder. The file causing this is a system-test, so this PR changes it to read at runtime the package.json file, this way it is not contained on the build folder.

Fixes #457 🦕

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. labels May 10, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label May 10, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 10, 2024
@alvarowolfx alvarowolfx merged commit c5f383b into googleapis:main May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.7.0 build folder has no build file

3 participants