This repository was archived by the owner on Mar 5, 2026. It is now read-only.
ci: fix npm pack/publish by removing import package.json#458
Merged
alvarowolfx merged 1 commit intogoogleapis:mainfrom May 10, 2024
Merged
Conversation
alexander-fenster
approved these changes
May 10, 2024
danielbankhead
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v4.7.0 was published with no source files. We managed to reproduce the issue by using
nvmand setting to node to v14 and npm v6, which seems to have issues when apackage.jsonexists on the build folder. The file causing this is asystem-test, so this PR changes it to read at runtime thepackage.jsonfile, this way it is not contained on the build folder.Fixes #457 🦕