Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

feat: add getWriteStream and createWriteStreamFullResponse methods#453

Merged
alvarowolfx merged 6 commits intogoogleapis:mainfrom
alvarowolfx:feat-get-write-stream
May 8, 2024
Merged

feat: add getWriteStream and createWriteStreamFullResponse methods#453
alvarowolfx merged 6 commits intogoogleapis:mainfrom
alvarowolfx:feat-get-write-stream

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

@alvarowolfx alvarowolfx commented May 6, 2024

Add wrapper for getWriteStream method. We can changes samples to use this method to get the table schema, instead of using the other BigQuery Node library.

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. labels May 6, 2024
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 6, 2024
@alvarowolfx alvarowolfx marked this pull request as ready for review May 6, 2024 19:07
@alvarowolfx alvarowolfx requested review from a team, leahecole, shollyman and yirutang and removed request for leahecole May 6, 2024 19:07
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
Comment thread samples/append_rows_buffered.js Outdated
Comment thread samples/append_rows_table_to_proto2.js Outdated
@alvarowolfx alvarowolfx changed the title feat: add getWriteStream method feat: add getWriteStream and createWriteStreamFullResponse methods May 6, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@alvarowolfx alvarowolfx added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2024
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 7, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label May 7, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 7, 2024
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we didn't need the custom name for the full creation response, but alas this seems a reasonable way to get around it without breaking usage.

@alvarowolfx alvarowolfx merged commit 27dce6a into googleapis:main May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants