This repository was archived by the owner on Mar 5, 2026. It is now read-only.
docs: change README to show Write veneer#452
Merged
alvarowolfx merged 14 commits intogoogleapis:mainfrom May 9, 2024
Merged
Conversation
alvarowolfx
added
the
owlbot:run
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
product-auto-label
Bot
added
size: m
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
product-auto-label
Bot
added
size: l
|
Warning: This pull request is touching the following templated files:
|
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
yirutang
reviewed
May 6, 2024
| try { | ||
| const dataset = bigquery.dataset(datasetId); | ||
| const table = await dataset.table(tableId); | ||
| const [metadata] = await table.getMetadata(); |
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
yirutang
approved these changes
May 7, 2024
shollyman
approved these changes
May 7, 2024
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
mostly just comments feedback. I didn't copy all comments to all files but they're likely relevant.
| > Node.js idiomatic client for [BigQuery Storage](https://cloud.google.com/bigquery). | ||
|
|
||
| The BigQuery Storage product is divided into two major APIs: Write and Read API. | ||
| Both BigQuery Storage APIs does not provide functionality related to managing |
Contributor
There was a problem hiding this comment.
Strange structure to this sentence. Possibly just want to remove the "Both" at the beginning and s/APIs/API/?
|
|
||
| async function bigqueryStorageWriteQuickstart() { | ||
| /** | ||
| * TODO(developer): Uncomment the following lines before ru nning the sample. |
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround to show Storage Write API as example on the README of this repo by adding another sample on the
quickstart.jsfile.We still keep the
bigquerystorage_quickstartsample to use the Read API, as that's what is being used in all languages and docs.