This repository was archived by the owner on Mar 5, 2026. It is now read-only.
fix: destroy internal grpc conn when closed#439
Merged
alvarowolfx merged 1 commit intogoogleapis:mainfrom Apr 15, 2024
Merged
Conversation
product-auto-label
Bot
added
size: xs
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
shollyman
approved these changes
Apr 11, 2024
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
I name thee....DESTROYER. Thanks for tracking this one down.
feywind
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where the connection was not used and ended, some errors can be raised and are not handled due to the internal event listeners being removed. This PR add code to destroy the internal grpc connection to ensure no errors are raised after it's closed.
Fixes #348 🦕