This repository was archived by the owner on Mar 5, 2026. It is now read-only.
fix: auto convert nested fields#438
Merged
alvarowolfx merged 6 commits intogoogleapis:mainfrom Apr 8, 2024
Merged
Conversation
product-auto-label
Bot
added
size: m
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
| value: any, | ||
| key: string, | ||
| ptype: protobuf.Type | ||
| ): any | null { |
Contributor
There was a problem hiding this comment.
you are returning undefined but this line says any | null. it works because any allows anything, but maybe it's better to say any | undefined?
Contributor
Author
There was a problem hiding this comment.
ah good catch, I started using null and later moved to undefined and forgot to change the signature.
alexander-fenster
approved these changes
Apr 8, 2024
Contributor
alexander-fenster
left a comment
alexander-fenster
left a comment
There was a problem hiding this comment.
In general, I would think if it's possible to replace all any with something more specific, at least maybe something like number | string | {} - not sure if it's at all possible in this kind of code that really works with arbitrary objects, but might still find an issue or two.
product-auto-label
Bot
added
size: l
alexander-fenster
approved these changes
Apr 8, 2024
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
product-auto-label
Bot
added
size: m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto converting types when automatically encoding JSON -> Protobuf was not working for nested structs (Arrays and Objects). This PR fix the behavior.
Related to #436 and #422