This repository was archived by the owner on Mar 5, 2026. It is now read-only.
feat: add wrapper for reading table data using Storage API#431
Merged
gcf-merge-on-green[bot] merged 33 commits intogoogleapis:mainfrom Sep 23, 2024
Merged
Conversation
product-auto-label
Bot
added
size: l
Contributor
Author
|
Some early results:
|
product-auto-label
Bot
added
size: xl
alvarowolfx
commented
Sep 3, 2024
Contributor
Author
alvarowolfx
left a comment
alvarowolfx
left a comment
There was a problem hiding this comment.
Added some more comments, address some minor issues and pushed a new test using CTA and generate_array to test it with more data cc @shollyman @leahecole
Comment on lines
+92
to
+95
| return stream | ||
| .pipe(new ArrowRawTransform()) | ||
| .pipe(new ArrowRecordReaderTransform(info!)) | ||
| .pipe(new ArrowRecordBatchTransform()) as ResourceStream<RecordBatch>; |
Contributor
Author
There was a problem hiding this comment.
Tried to use pipeline, but is meant to be used when we have a destination. In this case where, we are just applying a bunch of transforms and we don't know the destination beforehand.
The error that I got:
TypeError [ERR_INVALID_ARG_TYPE]: The "streams[stream.length - 1]" property must be of type function. Received an instance of ArrowRecordBatchTransform
Comment on lines
+99
to
+101
| return stream.pipe( | ||
| new ArrowRecordBatchTableRowTransform() | ||
| ) as ResourceStream<TableRow>; |
Contributor
Author
There was a problem hiding this comment.
Errors are handled by the consumer of the stream and when used internally like here, we handle the errors.
shollyman
approved these changes
Sep 4, 2024
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
automerge
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
automerge
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
removed
the
automerge
leahecole
approved these changes
Sep 23, 2024
alvarowolfx
added
automerge
gcf-owl-bot
Bot
removed
the
owlbot:run
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for easily reading Tables using the BigQuery Storage API instead of the BigQuery API. This will provide increased performance and reduced memory usage for most use cases and will allow users to keep using the same interface as they used to use on our main library or fetch data directly via a new veneer on BigQuery Storage Read API