Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

fix: handle more scenarios for stream reconnection#429

Merged
alvarowolfx merged 6 commits intogoogleapis:mainfrom
alvarowolfx:fix-reconnect-abort
Mar 20, 2024
Merged

fix: handle more scenarios for stream reconnection#429
alvarowolfx merged 6 commits intogoogleapis:mainfrom
alvarowolfx:fix-reconnect-abort

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

The BigQuery service now return Code:10 Aborted when a connection is idle for to long, to force reconnection.

Fixes #427 🦕

@alvarowolfx alvarowolfx requested a review from a team March 15, 2024 16:23
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Mar 15, 2024
@alvarowolfx alvarowolfx added owlbot:run Add this label to trigger the Owlbot post processor. and removed size: m Pull request size is medium. labels Mar 15, 2024
@product-auto-label product-auto-label Bot added the api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. label Mar 15, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2024
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request to widen the predicate, otherwise looks good.

Comment thread src/managedwriter/stream_connection.ts Outdated
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Mar 18, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 19, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 19, 2024
Comment thread system-test/managed_writer_client_test.ts Outdated
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 19, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 19, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2024
@alvarowolfx alvarowolfx merged commit e6f9323 into googleapis:main Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Closing the stream because it has been inactive for 600 seconds

3 participants