Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

feat: add support for missing value interpretation#428

Merged
gcf-merge-on-green[bot] merged 9 commits intogoogleapis:mainfrom
alvarowolfx:feat-default-value-interpretation
Mar 21, 2024
Merged

feat: add support for missing value interpretation#428
gcf-merge-on-green[bot] merged 9 commits intogoogleapis:mainfrom
alvarowolfx:feat-default-value-interpretation

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

@alvarowolfx alvarowolfx commented Mar 13, 2024

Fixes #426 🦕

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. labels Mar 13, 2024
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 15, 2024
@alvarowolfx alvarowolfx marked this pull request as ready for review March 15, 2024 20:17
@alvarowolfx alvarowolfx requested a review from a team March 15, 2024 20:17
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2024
shollyman
shollyman reviewed Mar 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this handwritten allow MVI changes when writes have already begun, or are the options locked at the outset only?

Comment thread system-test/managed_writer_client_test.ts Outdated
const protoDescriptor: DescriptorProto =
adapt.convertStorageSchemaToProto2Descriptor(storageSchema, 'root');

// Row 1
Copy link
Copy Markdown
Contributor

@shollyman shollyman Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sample rows are confusing, as the row data isn't compatible with the updatedSchema above. If you're wanting empty rows that's fine, just describe what you're doing so the interaction is clearer.

Copy link
Copy Markdown
Contributor Author

@alvarowolfx alvarowolfx Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed some updates to the test to make the full schema more explicit. The idea here is to send rows with some empty values and show that they are being filled or not accordingly to the MVI settings.

@alvarowolfx alvarowolfx changed the title feat: add support for default value interpretation feat: add support for missing value interpretation Mar 18, 2024
@alvarowolfx
Copy link
Copy Markdown
Contributor Author

alvarowolfx commented Mar 20, 2024

Does this handwritten allow MVI changes when writes have already begun, or are the options locked at the outset only?

Both Writer and JSONWriter have the methods setDefaultMissingValueInterpretation and setMissingValueInterpretations to change MVI after the writer is already started.

@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 20, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2024
feywind
feywind approved these changes Mar 20, 2024
View reviewed changes
Comment thread src/managedwriter/json_writer.ts Outdated
}

/**
* Update how missing values are interpreted by for the given stream.
Copy link
Copy Markdown

@feywind feywind Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 'by' is extra in there.

Comment thread src/managedwriter/writer.ts Outdated
protoDescriptor: IDescriptorProto;

/**
* Controls how missing values are interpreted by for a given stream.
Copy link
Copy Markdown

@feywind feywind Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the extra 'by' too.

Comment thread src/managedwriter/writer.ts Outdated
}

/**
* Update how missing values are interpreted by for the given stream.
Copy link
Copy Markdown

@feywind feywind Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another 'by'

shollyman
shollyman approved these changes Mar 21, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, comment nits seem to be the last bit to address.

I do wish the assertion support was better here and isnull/notnull were first class assertions, but alas.

Comment thread src/managedwriter/writer.ts Outdated

/**
* Controls how missing values are interpreted by for a given stream.
* `missingValueInterpretations` set for individual colums can override the default chosen
Copy link
Copy Markdown
Contributor

@shollyman shollyman Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/colums/columns/

@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2024
@alvarowolfx alvarowolfx added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 21, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2024
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 1a3e4ba into googleapis:main Mar 21, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 21, 2024
@release-please release-please Bot mentioned this pull request Mar 21, 2024
Merged
@release-please release-please Bot mentioned this pull request Aug 13, 2025
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@shollyman shollyman shollyman approved these changes

@feywind feywind feywind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default expression does not work

3 participants

@alvarowolfx @shollyman @feywind