Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

fix: struct field names should not be lowercase#364

Merged
alvarowolfx merged 3 commits intogoogleapis:mainfrom
alvarowolfx:fix-lowercase-struct-field
Aug 18, 2023
Merged

fix: struct field names should not be lowercase#364
alvarowolfx merged 3 commits intogoogleapis:mainfrom
alvarowolfx:fix-lowercase-struct-field

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

Fixes #358 🦕

@alvarowolfx alvarowolfx requested a review from a team August 11, 2023 15:44
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. labels Aug 11, 2023
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2023
@alvarowolfx alvarowolfx added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@alvarowolfx alvarowolfx requested a review from loferris August 15, 2023 21:19
Copy link
Copy Markdown
Contributor

@loferris loferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2023
Copy link
Copy Markdown

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting Lo

@alvarowolfx alvarowolfx merged commit 1867062 into googleapis:main Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adapt.convertStorageSchemaToProto2Descriptor converts Record column names to lower case

5 participants