Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

docs: augment write API sample to add more types#288

Merged
shollyman merged 8 commits intogoogleapis:mainfrom
shollyman:complex-schema
Aug 23, 2022
Merged

docs: augment write API sample to add more types#288
shollyman merged 8 commits intogoogleapis:mainfrom
shollyman:complex-schema

Conversation

@shollyman
Copy link
Copy Markdown
Contributor

This PR adds some missing functionality to the appending data
example for node, namely to demonstrate writing complex messages
with nested message types.

It augments the sample data proto to be in line with other languages
and adds the testing to ensure that complex types are propagated
through to query results.

This PR adds some missing functionality to the appending data
example for node, namely to demonstrate writing complex messages
with nested message types.

It augments the sample data proto to be in line with other languages
and adds the testing to ensure that complex types are propagated
through to query results.
@shollyman shollyman requested review from a team and loferris August 22, 2022 20:56
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. samples Issues that are directly related to samples. labels Aug 22, 2022
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Aug 22, 2022

Warning: This pull request is touching the following templated files:

@shollyman shollyman added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@shollyman shollyman requested a review from alvarowolfx August 22, 2022 21:46
Copy link
Copy Markdown
Contributor

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@loferris loferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2022
@shollyman shollyman merged commit 5866ec3 into googleapis:main Aug 23, 2022
@shollyman shollyman deleted the complex-schema branch August 23, 2022 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants