Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

refactor(types): refactors index to export all types#548

Merged
steffnay merged 15 commits intogoogleapis:masterfrom
steffnay:export-types
Oct 30, 2019
Merged

refactor(types): refactors index to export all types#548
steffnay merged 15 commits intogoogleapis:masterfrom
steffnay:export-types

Conversation

@steffnay
Copy link
Copy Markdown
Contributor

@steffnay steffnay commented Sep 21, 2019

Fixes #456

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 21, 2019

Codecov Report

Merging #548 into master will increase coverage by <.01%.
The diff coverage is 98.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
+ Coverage   99.42%   99.43%   +<.01%     
==========================================
  Files           5        6       +1     
  Lines         698      707       +9     
  Branches      192      192              
==========================================
+ Hits          694      703       +9     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/dataset.ts 100% <ø> (ø) ⬆️
src/table.ts 100% <ø> (ø) ⬆️
src/job.ts 100% <ø> (ø) ⬆️
src/index.ts 100% <100%> (+1.49%) ⬆️
src/bigquery.ts 98.47% <98.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec07f9...49c11bb. Read the comment docs.

@bcoe
Copy link
Copy Markdown

bcoe commented Oct 1, 2019

@stephenplusplus I believe @callmehiphop might be away for a little bit? mind providing some review.

Comment thread benchmark/bench.ts Outdated
Comment thread src/job.ts Outdated
Comment thread src/table.ts Outdated
Comment thread src/bigquery.ts Outdated
@steffnay steffnay requested a review from callmehiphop October 14, 2019 00:47
Comment thread test/bigquery.ts Outdated
@steffnay steffnay requested a review from callmehiphop October 28, 2019 17:07
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2019
@bcoe bcoe added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 28, 2019
@steffnay steffnay merged commit e7685c6 into googleapis:master Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't Import Useful Types From Main Declaration File

6 participants