Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: correctly encode nested custom date/time parameters#393

Merged
callmehiphop merged 2 commits intogoogleapis:masterfrom
callmehiphop:dg--392
Mar 21, 2019
Merged

fix: correctly encode nested custom date/time parameters#393
callmehiphop merged 2 commits intogoogleapis:masterfrom
callmehiphop:dg--392

Conversation

@callmehiphop
Copy link
Copy Markdown
Contributor

@callmehiphop callmehiphop commented Mar 20, 2019

Fixes #392

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2019

Codecov Report

Merging #393 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   99.44%   99.45%   +<.01%     
==========================================
  Files           4        4              
  Lines         544      547       +3     
  Branches       75       76       +1     
==========================================
+ Hits          541      544       +3     
  Misses          2        2              
  Partials        1        1
Impacted Files Coverage Δ
src/index.ts 98.55% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf9e89...83e2c97. Read the comment docs.

@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2019
@callmehiphop callmehiphop merged commit ba5c82e into googleapis:master Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants