This repository was archived by the owner on Feb 7, 2026. It is now read-only.
refactor(samples): split query and table samples into separate files#384
Merged
JustinBeckwith merged 10 commits intogoogleapis:masterfrom Mar 15, 2019
steffnay:update-to-snippet-rubric
Merged
refactor(samples): split query and table samples into separate files#384JustinBeckwith merged 10 commits intogoogleapis:masterfrom steffnay:update-to-snippet-rubric
JustinBeckwith merged 10 commits intogoogleapis:masterfrom
steffnay:update-to-snippet-rubric
Conversation
Contributor
steffnay
commented
Mar 15, 2019
steffnay
commented
- Tests and linter pass
- Code coverage does not decrease (if any source code was changed)
- Appropriate docs were updated (if necessary)
googlebot
added
the
cla: yes
jkwlui
approved these changes
Mar 15, 2019
jkwlui
suggested changes
Mar 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 4 4
Lines 544 544
Branches 75 75
=======================================
Hits 541 541
Misses 2 2
Partials 1 1Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Mar 15, 2019
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
Can you please delete samples/default.profraw? Other than that, LGTM
JustinBeckwith
approved these changes
Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.