Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

docs(samples): adds queryParamsNamed and queryParamsPositional#381

Merged
JustinBeckwith merged 5 commits intogoogleapis:masterfrom
steffnay:78026053
Mar 15, 2019
Merged

docs(samples): adds queryParamsNamed and queryParamsPositional#381
JustinBeckwith merged 5 commits intogoogleapis:masterfrom
steffnay:78026053

Conversation

@steffnay
Copy link
Copy Markdown
Contributor

@steffnay steffnay commented Mar 14, 2019

Fixes 380

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2019
JustinBeckwith
JustinBeckwith suggested changes Mar 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there are a lot of comments here - but it's not your fault at all. Running repo-tools blasts away a lot of things that shouldn't be changed, so you have to kinda be careful about what gets committed. Apologies!

Comment thread .eslintignore
Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/ISSUE_TEMPLATE.md Outdated
Comment thread .gitignore
Comment thread .jsdoc.js
Comment thread .nycrc
Comment thread README.md Outdated
Comment thread samples/README.md
Comment thread samples/system-test/.eslintrc.yml Outdated
Comment thread system-test/.eslintrc.yml Outdated
@steffnay steffnay requested a review from JustinBeckwith March 15, 2019 17:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2019 •
edited
Loading

Codecov Report

Merging #381 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #381   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files           4        4           
  Lines         544      544           
  Branches       75       75           
=======================================
  Hits          541      541           
  Misses          2        2           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8caa112...f9ec888. Read the comment docs.

@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2019
@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Mar 15, 2019

@JustinBeckwith please force merge this. It has 2 links that links to code in samples/ which doesn't exist yet unless merged to master:

[404] https://github.com/googleapis/nodejs-bigquery/blob/master/samples/queryParamsNamed.js
[404] https://github.com/googleapis/nodejs-bigquery/blob/master/samples/queryParamsPositional.js

@JustinBeckwith JustinBeckwith merged commit 2383b70 into googleapis:master Mar 15, 2019
tswast
tswast reviewed Mar 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkwlui jkwlui Awaiting requested review from jkwlui

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

2 more reviewers

@tswast tswast tswast left review comments

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@steffnay @jkwlui @tswast @JustinBeckwith @googlebot