testing: remove nextQuery assertion#377
testing: remove nextQuery assertion#377callmehiphop merged 1 commit intogoogleapis:masterfrom callmehiphop:dg--375
Conversation
googlebot
added
the
cla: yes
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
looks good to me 👍 is there a tracking issue to try to reset state between tests runs, this can definitely start to make for hard to debug test suites.
| filter: `labels.${GCLOUD_TESTS_PREFIX}`, | ||
| }); | ||
| assert(datasets[0] instanceof Dataset); | ||
| assert.strictEqual(nextQuery, null); |
There was a problem hiding this comment.
seems reasonable to me; in a perfect world, I might try to have a beforeEach that ensures that there's nothing populated in nextQuery before running the test. Is there a tracking issue for this bug? (state between tests can really start to be a pain).
There was a problem hiding this comment.
I don't think there is, @JustinBeckwith might know though?
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 4 4
Lines 544 544
Branches 75 75
=======================================
Hits 541 541
Misses 2 2
Partials 1 1Continue to review full report at Codecov.
|
4 participants
Fixes #375
Since we refactored our strategy for dealing with lingering resources, sometimes
nextQuerywill be populated with a page of resources from a different test run.