This repository was archived by the owner on Feb 7, 2026. It is now read-only.
fix: update samples and docs to match rubric#374
Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom Mar 10, 2019
JustinBeckwith:docsy
Merged
fix: update samples and docs to match rubric#374JustinBeckwith merged 2 commits intogoogleapis:masterfrom JustinBeckwith:docsy
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
JustinBeckwith:docsy
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 4 4
Lines 544 544
Branches 75 75
=======================================
Hits 541 541
Misses 2 2
Partials 1 1Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So... I made a few mistakes. During the code review of #368, a few things slipped:
bigquery_dataset_bleh.jstocreateDataset.jscloud-repo-tools.jsonto include the new samples