This repository was archived by the owner on Feb 7, 2026. It is now read-only.
refactor(samples): split samples into their own files#368
Merged
JustinBeckwith merged 8 commits intogoogleapis:masterfrom Mar 8, 2019
steffnay:standards-update
Merged
refactor(samples): split samples into their own files#368JustinBeckwith merged 8 commits intogoogleapis:masterfrom steffnay:standards-update
JustinBeckwith merged 8 commits intogoogleapis:masterfrom
steffnay:standards-update
Conversation
googlebot
added
the
cla: yes
JustinBeckwith
suggested changes
Mar 6, 2019
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
Congrats on the first PR in this repo! When filing PRs in nodejs land, we really like to use the conventional commits format. It makes things a lot easier when figuring out what's happening in a change log.
Could you rename this PR (and the resulting commit) to something like:
refactor(samples): split samples into their own files
Thanks!
steffnay
changed the title
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 4 4
Lines 544 544
Branches 75 75
=======================================
Hits 541 541
Misses 2 2
Partials 1 1Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Mar 8, 2019
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tswast
reviewed
Mar 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #367