This repository was archived by the owner on Feb 7, 2026. It is now read-only.
test: skip installation test if GOOGLE_CLOUD_TESTS_IN_VPCSC is passed#345
Merged
JustinBeckwith merged 12 commits intomasterfrom Feb 15, 2019
Merged
test: skip installation test if GOOGLE_CLOUD_TESTS_IN_VPCSC is passed#345JustinBeckwith merged 12 commits intomasterfrom
JustinBeckwith merged 12 commits intomasterfrom
Conversation
googlebot
added
the
cla: yes
callmehiphop
approved these changes
Feb 6, 2019
JustinBeckwith
suggested changes
Feb 6, 2019
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
Instead of this - could we do the thing you did in storage where we looked for an env var, and did an explicit skip? I don't want the kokoro configs straying if we can at all avoid it.
Contributor
Author
|
I changed it to use the environment variable to determine whether or not to skip install-test, but I still kept it split out |
jkwlui
changed the title
JustinBeckwith
approved these changes
Feb 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 4 4
Lines 544 544
Branches 75 75
=======================================
Hits 541 541
Misses 2 2
Partials 1 1Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out install-test as a separate npm run-script instead of bundling
with system-test.
This helps unblock VPCSC testing since it can't fetch external
dependencies with npm install when installation test does npm pack