Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: throw errors for missing resource ids#342

Merged
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
callmehiphop:dg--325
Feb 5, 2019
Merged

feat: throw errors for missing resource ids#342
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
callmehiphop:dg--325

Conversation

@callmehiphop
Copy link
Copy Markdown
Contributor

@callmehiphop callmehiphop commented Feb 1, 2019 •
edited
Loading

Fixes #325

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2019
@callmehiphop callmehiphop requested review from a team and stephenplusplus February 1, 2019 22:56
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2019
@JustinBeckwith JustinBeckwith merged commit a1c9e3d into googleapis:master Feb 5, 2019
@release-please release-please Bot mentioned this pull request May 18, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@callmehiphop @JustinBeckwith @googlebot @kokoro-team