Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix(types): add missing parameters (selectedFields, startIndex) in table.getRows() options#331

Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
lostpebble:add-types-table-get-rows
Jan 17, 2019
Merged

fix(types): add missing parameters (selectedFields, startIndex) in table.getRows() options#331
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
lostpebble:add-types-table-get-rows

Conversation

@lostpebble
Copy link
Copy Markdown
Contributor

Fixes #330

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [] Appropriate docs were updated (if necessary)

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 17, 2019
@lostpebble
Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 17, 2019
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2019
@JustinBeckwith JustinBeckwith changed the title Add missing parameters (selectedFields, startIndex) in table.getRows() options fix(types): add missing parameters (selectedFields, startIndex) in table.getRows() options Jan 17, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2019
@JustinBeckwith JustinBeckwith merged commit fb0d769 into googleapis:master Jan 17, 2019
@lostpebble
Copy link
Copy Markdown
Contributor Author

No worries! I was happy to make the relevant changes to the docs too, but not sure exactly where to do that.

@lostpebble lostpebble deleted the add-types-table-get-rows branch January 30, 2019 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants