This repository was archived by the owner on Feb 7, 2026. It is now read-only.
fix: correctly iterate query results within stream#323
Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom Jan 8, 2019
Merged
fix: correctly iterate query results within stream#323JustinBeckwith merged 1 commit intogoogleapis:masterfrom
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
Conversation
|
Woo! Thanks for the amazingly fast fix. Glad you were able to follow my code diving :) |
stephenplusplus
commented
Jan 8, 2019
| */ | ||
| queryAsStream_(query: Query, callback?: SimpleQueryRowsCallback) { | ||
| if (query.job) { | ||
| query.job.getQueryResults(query, callback as QueryRowsCallback); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@oliverwoodings it's your patience going through all of that that is most impressive :D |
JustinBeckwith
approved these changes
Jan 8, 2019
jkwlui
approved these changes
Jan 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #303
In a stream, we-- y'know what, @oliverwoodings explained it best: #303 (comment)