Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: correctly iterate query results within stream#323

Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
stephenplusplus:spp--303
Jan 8, 2019
Merged

fix: correctly iterate query results within stream#323
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
stephenplusplus:spp--303

Conversation

@stephenplusplus
Copy link
Copy Markdown
Contributor

Fixes #303

In a stream, we-- y'know what, @oliverwoodings explained it best: #303 (comment)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2019
@oliverwoodings
Copy link
Copy Markdown

Woo! Thanks for the amazingly fast fix. Glad you were able to follow my code diving :)

Comment thread src/index.ts
*/
queryAsStream_(query: Query, callback?: SimpleQueryRowsCallback) {
if (query.job) {
query.job.getQueryResults(query, callback as QueryRowsCallback);

This comment was marked as spam.

@stephenplusplus
Copy link
Copy Markdown
Contributor Author

@oliverwoodings it's your patience going through all of that that is most impressive :D

@JustinBeckwith JustinBeckwith merged commit 734e4e2 into googleapis:master Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants