Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: remove Job.setMetadata method#319

Merged
jkwlui merged 2 commits intomasterfrom
remove-job-setmetadata
Dec 27, 2018
Merged

fix: remove Job.setMetadata method#319
jkwlui merged 2 commits intomasterfrom
remove-job-setmetadata

Conversation

@jkwlui
Copy link
Copy Markdown
Contributor

@jkwlui jkwlui commented Dec 27, 2018

BigQuery/Jobs API doesn't (no longer?) support PATCH method on jobs.

I'm not sure if it used to, @stephenplusplus, but the REST reference doesn't show a PATCH method.

When attempting to call Job.setMetadata, the promise rejects citing "Unable to parse JSON" because the server returned a 404 HTML response saying the method is not found.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 27, 2018
@jkwlui jkwlui requested a review from a team December 27, 2018 00:04
@jkwlui jkwlui self-assigned this Dec 27, 2018
Copy link
Copy Markdown
Contributor

@stephenplusplus stephenplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of weird. I would guess we enabled setMetadata by mistake for the Jobs API.

@jkwlui jkwlui merged commit 0dd0d51 into master Dec 27, 2018
@jkwlui jkwlui deleted the remove-job-setmetadata branch December 27, 2018 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants