fix(test): labels: should be an object, not array#315
Conversation
bfb9a65 to
a7e95e5
Compare
|
The remaining system-test failure is a little frustrating.. it is intermittent and I often have to run the system tests several times before getting it Upon logging the response bodies, I found that the server is returning 2 sets of response bodies for the same request: body {
"error": {
"errors": [
{
"domain": "global",
"reason": "conditionNotMet",
"message": "Precondition Failed",
"locationType": "header",
"location": "If-Match"
}
],
"code": 412,
"message": "Precondition Failed"
}
}body {
"error": {
"code": 400,
"message": "Precondition check failed.",
"errors": [
{
"message": "Precondition check failed.",
"domain": "global",
"reason": "failedPrecondition"
}
],
"status": "FAILED_PRECONDITION"
}
}But the weird thing is both responses give the 412 HTTP status code in the response header. When we parse the body, we override the status code returned to the client via |
|
Anyhow, it's probably unrelated to the test failure fixed by this PR, so let's merge this and I'll file an issue with the team. |
|
Woah, that's wild. Filing a bug with the partner team feels like the right move. In the interim, I'm supportive of a retry or skip until the underlying API issue is resolved. |
🤦♂️