Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix(ts): explicit usage of Duplex#300

Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
bchhun:bug/using-duplex-explicitly
Dec 10, 2018
Merged

fix(ts): explicit usage of Duplex#300
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
bchhun:bug/using-duplex-explicitly

Conversation

@bchhun
Copy link
Copy Markdown
Contributor

@bchhun bchhun commented Dec 10, 2018

because otherwise, we get syntax error messages when we try to import bigquery in another project

Fixes #299 (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

The npm run lint command has errors but not explicitly in the part I've modified:

❯ npm run lint

> @google-cloud/[email protected] lint /Users/bchhun/projects/nodejs-bigquery
> gts check && eslint samples/


/Users/bchhun/projects/nodejs-bigquery/samples/datasets.js
  21:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  41:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  64:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require

/Users/bchhun/projects/nodejs-bigquery/samples/queries.js
  22:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  66:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  97:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require

/Users/bchhun/projects/nodejs-bigquery/samples/quickstart.js
  20:28  error  "@google-cloud/bigquery" is not found  node/no-missing-require

/Users/bchhun/projects/nodejs-bigquery/samples/system-test/datasets.test.js
  18:28  error  "@google-cloud/bigquery" is not found  node/no-missing-require

/Users/bchhun/projects/nodejs-bigquery/samples/system-test/tables.test.js
  23:28  error  "@google-cloud/bigquery" is not found  node/no-missing-require

/Users/bchhun/projects/nodejs-bigquery/samples/tables.js
   21:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
   49:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
   74:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
   96:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  128:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  161:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  193:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  242:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  291:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  358:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  417:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  472:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  526:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  588:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  649:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  704:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  765:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require
  805:30  error  "@google-cloud/bigquery" is not found  node/no-missing-require

✖ 27 problems (27 errors, 0 warnings)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/[email protected] lint: `gts check && eslint samples/`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @google-cloud/[email protected] lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/bchhun/.npm/_logs/2018-12-10T22_40_17_760Z-debug.log

@bchhun
bug: explicit usage of Duplex
8d2baad 
because otherwise, we get syntax error messages when we try to import bigquery in another project
@googlebot
Copy link
Copy Markdown

googlebot commented Dec 10, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 10, 2018
@bchhun
Copy link
Copy Markdown
Contributor Author

bchhun commented Dec 10, 2018

I signed it!

@googlebot
Copy link
Copy Markdown

googlebot commented Dec 10, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 10, 2018
JustinBeckwith
JustinBeckwith approved these changes Dec 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@JustinBeckwith JustinBeckwith changed the title bug: explicit usage of Duplex fix(ts): explicit usage of Duplex Dec 10, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2018
@JustinBeckwith JustinBeckwith merged commit 9199ce4 into googleapis:master Dec 10, 2018
@release-please release-please Bot mentioned this pull request May 18, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bchhun @googlebot @JustinBeckwith @kokoro-team