This repository was archived by the owner on Feb 7, 2026. It is now read-only.
fix(docs): move comments above last overload#292
Merged
Conversation
googlebot
added
the
cla: yes
jkwlui
force-pushed
the
fix-overload-jsdoc
branch
from
9d4e1d6 to
bdefb1d
Compare
JustinBeckwith
approved these changes
Dec 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
during typescript compilation, the comments above the first overload gets stripped off. The doc comments need to be placed right above the last overload.