Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

Add types proxyquire#256

Merged
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
iida-hayato:add-types-proxyquire
Nov 8, 2018
Merged

Add types proxyquire#256
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
iida-hayato:add-types-proxyquire

Conversation

@iida-hayato
Copy link
Copy Markdown
Contributor

@iida-hayato iida-hayato commented Nov 6, 2018

Related #251

there is Error:(24, 29) TS2307: Cannot find module 'proxyquire'. when 'noImplicitAny: true' in tsconfig.json
So,I add @types/proxyquire

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2018
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JustinBeckwith JustinBeckwith merged commit 97ccb66 into googleapis:master Nov 8, 2018
@iida-hayato iida-hayato deleted the add-types-proxyquire branch November 8, 2018 04:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants