Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

nodejs-bigquery - convert samples test ava to mocha#248

Merged
JustinBeckwith merged 10 commits intogoogleapis:masterfrom
vijay-qlogic:ava-to-mocha
Nov 22, 2018
Merged

nodejs-bigquery - convert samples test ava to mocha#248
JustinBeckwith merged 10 commits intogoogleapis:masterfrom
vijay-qlogic:ava-to-mocha

Conversation

@vijay-qlogic
Copy link
Copy Markdown
Contributor

@vijay-qlogic vijay-qlogic commented Nov 1, 2018

Fixes #Convert all sample tests to mocha (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2018
JustinBeckwith
JustinBeckwith suggested changes Nov 2, 2018
View reviewed changes
Comment thread samples/package.json
Comment thread samples/system-test/datasets.test.js
Comment thread samples/system-test/quickstart.test.js
Comment thread samples/system-test/quickstart.test.js
Comment thread samples/system-test/quickstart.test.js Outdated
Comment thread samples/system-test/quickstart.test.js Outdated
@JustinBeckwith
Copy link
Copy Markdown
Contributor

JustinBeckwith commented Nov 8, 2018

👋 gentle ping

@vijay-qlogic vijay-qlogic force-pushed the ava-to-mocha branch 2 times, most recently from 2d4c9a1 to bde4be0 Compare November 15, 2018 14:35
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2018
@vijay-qlogic
Copy link
Copy Markdown
Contributor Author

vijay-qlogic commented Nov 20, 2018

@JustinBeckwith strange! locally all tests passing form me, but not here

@JustinBeckwith
Copy link
Copy Markdown
Contributor

JustinBeckwith commented Nov 20, 2018

So this will sound crazy. Try pinning @types/sinon to version 5.0.5 with no range specifier, and see if it works.

@JustinBeckwith
Copy link
Copy Markdown
Contributor

JustinBeckwith commented Nov 20, 2018

Heh apologies - I meant in the root package.json, not samples/package.json

@vijay-qlogic
Copy link
Copy Markdown
Contributor Author

vijay-qlogic commented Nov 20, 2018

Worked 👍

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2018
@JustinBeckwith JustinBeckwith merged commit 834b18f into googleapis:master Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vijay-qlogic @JustinBeckwith @googlebot @kokoro-team