Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

BigQuery Orc & Parquet Samples#195

Merged
JustinBeckwith merged 5 commits intogoogleapis:masterfrom
alixhami:bq-orc-samples
Sep 17, 2018
Merged

BigQuery Orc & Parquet Samples#195
JustinBeckwith merged 5 commits intogoogleapis:masterfrom
alixhami:bq-orc-samples

Conversation

@alixhami
Copy link
Copy Markdown
Contributor

@alixhami alixhami commented Sep 17, 2018

This PR:

  • Adds load truncate samples for Orc and Parquet file formats
  • Adds load, load autodetect, and load truncate samples for JSON
  • Updates Orc and Parquet samples to not specify schema. The schema is inferred for these formats, so it should not be supplied (sources: parquet schemas, orc schemas)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2018
@alixhami
Copy link
Copy Markdown
Contributor Author

alixhami commented Sep 17, 2018

I did not regenerate the readme because npm run generate-scaffolding did not run. I got this error:

~/nodejs-bigquery [bq-orc-samples] $ npm run generate-scaffolding
npm ERR! missing script: generate-scaffolding

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/ajhamilton/.npm/_logs/2018-09-17T22_27_15_264Z-debug.log

tswast
tswast reviewed Sep 17, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tswast
tswast reviewed Sep 17, 2018
View reviewed changes
Comment thread samples/tables.js Outdated
{name: 'post_abbr', type: 'STRING'},
],
},
sourceFormat: 'ORC'

This comment was marked as spam.

Sign in to view

@JustinBeckwith JustinBeckwith merged commit 97d0df6 into googleapis:master Sep 17, 2018
@alixhami alixhami deleted the bq-orc-samples branch September 17, 2018 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@tswast tswast tswast left review comments

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alixhami @tswast @JustinBeckwith @googlebot