This repository was archived by the owner on Feb 7, 2026. It is now read-only.
chore: make ci happy#175
Merged
stephenplusplus merged 2 commits intogoogleapis:masterfrom Aug 27, 2018
callmehiphop:dg--174
Merged
chore: make ci happy#175stephenplusplus merged 2 commits intogoogleapis:masterfrom callmehiphop:dg--174
stephenplusplus merged 2 commits intogoogleapis:masterfrom
callmehiphop:dg--174
Conversation
ghost
assigned
googlebot
added
the
cla: yes
| baseUrl: '/datasets', | ||
| id: id, | ||
| methods: methods, | ||
| requestModule: request, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * }); | ||
| */ | ||
| createWriteStream(metadata) { | ||
| createWriteStream_(metadata) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@JustinBeckwith is there something special I need to do to get kokoro passing? |
JustinBeckwith
approved these changes
Aug 24, 2018
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
LGTM, but let @stephenplusplus give it a 👍 too :)
stephenplusplus
approved these changes
Aug 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174
Closes #173
The original issue being addressed (#174) was remedied by simply upgrading the common package. However additional bugs were identified after that were introduced via #85. A second commit to fix said bug was created.