Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: convert to TypeScript#157

Merged
JustinBeckwith merged 7 commits intogoogleapis:masterfrom
JustinBeckwith:typescript
Aug 6, 2018
Merged

feat: convert to TypeScript#157
JustinBeckwith merged 7 commits intogoogleapis:masterfrom
JustinBeckwith:typescript

Conversation

@JustinBeckwith
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith commented Aug 4, 2018

BREAKING CHANGE: The BigQuery object must now be instantiated.

Old Code

var bigquery = require('@google-cloud/bigquery')();

New Code

const BigQuery = require('@google-cloud/bigquery');
const bigquery = new BigQuery();

Step 1 of many.

@ghost ghost assigned JustinBeckwith Aug 4, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 4, 2018
@JustinBeckwith JustinBeckwith requested a review from a team August 4, 2018 18:13
@crwilcox
Copy link
Copy Markdown
Contributor

crwilcox commented Aug 6, 2018

I may have missed it, but is there a change to our build/publish for this so customers still get .js?

@JustinBeckwith
Copy link
Copy Markdown
Contributor Author

@JustinBeckwith JustinBeckwith merged commit 489bbec into googleapis:master Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants