This repository was archived by the owner on Feb 7, 2026. It is now read-only.
chore(package): update to the latest @google-cloud/common#146
Merged
stephenplusplus merged 3 commits intomasterfrom Jul 31, 2018
Merged
chore(package): update to the latest @google-cloud/common#146stephenplusplus merged 3 commits intomasterfrom
stephenplusplus merged 3 commits intomasterfrom
Conversation
ghost
assigned
JustinBeckwith
requested review from
alexander-fenster,
callmehiphop and
stephenplusplus
and removed request for
alexander-fenster
|
|
||
| it('should promisify all the things', function() { | ||
| assert(promisified); | ||
| assert(job.getQueryResults.promisified_); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 713 713
=====================================
Hits 713 713Continue to review full report at Codecov.
|
Contributor
Author
|
@stephenplusplus was able to just get rid of this all together 😄 |
stephenplusplus
approved these changes
Jul 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.