Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: throw timeout error when using jobs.query#1402

Merged
alvarowolfx merged 6 commits intogoogleapis:mainfrom
alvarowolfx:fix-query-timeout
Sep 23, 2024
Merged

fix: throw timeout error when using jobs.query#1402
alvarowolfx merged 6 commits intogoogleapis:mainfrom
alvarowolfx:fix-query-timeout

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

Properly handle timeout when going thought the fast query path and jobs.queryAPI method.

Fixes #1399 🦕

@alvarowolfx alvarowolfx requested review from a team, hongalex, leahecole and shollyman and removed request for hongalex September 10, 2024 20:43
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Sep 10, 2024
Copy link
Copy Markdown
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super small stuff, mostly questions and hardening up tests

Comment thread src/bigquery.ts
Comment thread src/bigquery.ts
Comment thread src/bigquery.ts
Comment thread system-test/bigquery.ts
Comment thread system-test/bigquery.ts
Comment thread src/bigquery.ts
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2024
@alvarowolfx alvarowolfx requested a review from a team September 23, 2024 16:18
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2024
@alvarowolfx alvarowolfx merged commit cf962a5 into googleapis:main Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several issues with stateless queries

2 participants